Make workspace data source uploads configurable#25012
Conversation
Update AI Management docs to describe configurable workspace data source upload options. Adds notes that allowed file extensions and max file size are configurable (default 10 MB), and that deleting a data source removes its embeddings, chunks, and blob. Introduces a new "Configuring Data Source Upload Options" section with a WorkspaceDataSourceOptions example (AllowedFileExtensions, MaxFileSize, ContentTypeMap), lists available properties and helper methods (GetMaxFileSizeDisplay, GetAllowedExtensionsDisplay, GetAcceptAttribute), and a note about registering content extractors for new file types. Also documents the WorkspaceDataSourceManager repository responsibility for full cleanup.
There was a problem hiding this comment.
Pull request overview
This PR updates the AI Management module documentation to describe the newly configurable workspace data source upload options. It clarifies that file extensions and max file size are no longer hardcoded, documents the cleanup behavior when deleting a data source, and introduces a full configuration reference for WorkspaceDataSourceOptions.
Changes:
- Adds
(configurable)annotations and a deletion cleanup note to the Workspace Data Sources section. - Introduces a new "Configuring Data Source Upload Options" sub-section with a code example, property table, helper method table, and an important note about registering content extractors.
- Extends the DELETE endpoint description and Domain Services list to reflect full cleanup behavior and the new
WorkspaceDataSourceManager.
| { | ||
| Configure<WorkspaceDataSourceOptions>(options => | ||
| { | ||
| // Add support for additional file types |
There was a problem hiding this comment.
The comment on line 403 says "Add support for additional file types," but the code on line 404 replaces the AllowedFileExtensions array entirely (overwriting the defaults .txt, .md, .pdf) rather than appending to them. This comment is misleading because readers might expect the code to append new extensions to the existing ones rather than replacing all of them. The comment should be updated to clarify that this line sets (replaces) the full list of allowed extensions.
| // Add support for additional file types | |
| // Set the full list of allowed file extensions (including additional types) |
Update AI Management docs to describe configurable workspace data source upload options. Adds notes that allowed file extensions and max file size are configurable (default 10 MB), and that deleting a data source removes its embeddings, chunks, and blob. Introduces a new "Configuring Data Source Upload Options" section with a WorkspaceDataSourceOptions example (AllowedFileExtensions, MaxFileSize, ContentTypeMap), lists available properties and helper methods (GetMaxFileSizeDisplay, GetAllowedExtensionsDisplay, GetAcceptAttribute), and a note about registering content extractors for new file types. Also documents the WorkspaceDataSourceManager repository responsibility for full cleanup.