Closed
Conversation
Author
|
Ah, I think I need to make the Blinder role work only when transactions are no longer under construction ... either that or implement compressed/uncompressed ASPs. |
achow101
force-pushed
the
pset-spec
branch
2 times, most recently
from
3b0435a to
3c3487c
Compare
Owner
|
Most of the changes here have been included with a manual update, along with other changes that were discussed offline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like the changes were really small - happily the bulk of the changes happened upstream in PSBT1->2.
The one controversial thing I did was adding a bit flag to
PSBT_GLOBAL_TX_MODIFIABLEinstead of using a proprietary field.I also did not update the "Unique Identification" section from PSBT2 to say that in addition to setting
nSequenceto 0 we should also use the explicit values/assets. Mainly because I'm not sure where to fit that paragraph into the doc.Will start working on implementing this with rust-elements and elements-miniscript and maybe double back to this.