Created env var for forcing node12 actions to run on node16#1913
Merged
thboop merged 11 commits intoactions:mainfrom Jun 22, 2022
ruvceskistefan:stefan-ruvceski/feature/1911
Merged
Created env var for forcing node12 actions to run on node16#1913thboop merged 11 commits intoactions:mainfrom ruvceskistefan:stefan-ruvceski/feature/1911
thboop merged 11 commits intoactions:mainfrom
ruvceskistefan:stefan-ruvceski/feature/1911
Conversation
thboop
reviewed
May 25, 2022
fhammerl
reviewed
Jun 1, 2022
fhammerl
reviewed
Jun 1, 2022
fhammerl
reviewed
Jun 1, 2022
Co-authored-by: Ferenc Hammerl <[email protected]>
Co-authored-by: Ferenc Hammerl <[email protected]>
fhammerl
reviewed
Jun 1, 2022
fhammerl
reviewed
Jun 1, 2022
TingluoHuang
reviewed
Jun 1, 2022
fhammerl
reviewed
Jun 1, 2022
fhammerl
reviewed
Jun 1, 2022
TingluoHuang
reviewed
Jun 7, 2022
fhammerl
reviewed
Jun 16, 2022
fhammerl
reviewed
Jun 16, 2022
thboop
reviewed
Jun 20, 2022
| { | ||
| var forcedNodeVersion = Environment.GetEnvironmentVariable(Constants.Variables.Agent.ForcedInternalNodeVersion); | ||
| return !string.IsNullOrEmpty(forcedNodeVersion) && BuiltInNodeVersions.Contains(forcedNodeVersion) ? forcedNodeVersion : _defaultNodeVersion; | ||
| var forcedInternalNodeVersion = Environment.GetEnvironmentVariable(Constants.Variables.Agent.ForcedInternalNodeVersion); |
Collaborator
There was a problem hiding this comment.
Is this just a refactor? It doesn't appear to do anything if i'm reading it correctly. Should we just revert these changes?
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1911