Conversation
tagliala
force-pushed
the
chore/update-dependencies
branch
from
24c85bc to
a3f790b
Compare
Pin zeitwerk to `~> 2.6.18` because 2.7.0 only supports Ruby >= 3.2
tagliala
force-pushed
the
chore/update-dependencies
branch
from
a3f790b to
a65915d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8501 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. |
tagliala
commented
Oct 12, 2024
Comment on lines
+22
to
+23
| # FIXME: relax this dependency when Ruby 3.1 support will be dropped | ||
| gem "zeitwerk", "~> 2.6.18" |
Contributor
Author
There was a problem hiding this comment.
I don't like this but I don't have better ideas.
With this approach, tests agains zeitwerk 2.7 will not be performed, which is not good
Member
There was a problem hiding this comment.
That's ok. I'm surprised they dropped support so soon. I'm fine with leaving this as is as I would have done the same, comment as well so it's easy to find. We'll address when it's time. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin zeitwerk to
~> 2.6.18because 2.7.0 only supports Ruby >= 3.2