Merged
Conversation
Running the spec suite with `RUBYOPT='-w'` to validate PR #8593 revealed numerous warnings related to ambiguous operators. To address these warnings, the `Lint/AmbiguousOperator` cop has been enabled and `rubocop -a` has been run to fix the offenses.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8594 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4076 4076
=======================================
Hits 4040 4040
Misses 36 36 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
I'll check arbre and inherited instruments |
tagliala
added a commit
to activeadmin/arbre
that referenced
this pull request
Jan 4, 2025
Parity with ActiveAdmin to prevent introduction of new warnings Ref: activeadmin/activeadmin#8594
tagliala
added a commit
to activeadmin/inherited_resources
that referenced
this pull request
Jan 4, 2025
Parity with ActiveAdmin to prevent introduction of new warnings Ref: activeadmin/activeadmin#8594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the spec suite with
RUBYOPT='-w'to validate PR #8593 revealed numerous warnings related to ambiguous operators.To address these warnings, the
Lint/AmbiguousOperatorcop has been enabled andrubocop -ahas been run to fix the offenses.This PR removes 122 warnings from the spec suite