Fix: Ensure Unique Tab IDs for Non-Latin Titles#8616
Closed
aalyahya wants to merge 2 commits intoactiveadmin:masterfrom
Closed
Fix: Ensure Unique Tab IDs for Non-Latin Titles#8616aalyahya wants to merge 2 commits intoactiveadmin:masterfrom
aalyahya wants to merge 2 commits intoactiveadmin:masterfrom
Conversation
…le and not passing custom id Fix issue in tabs when using non-English letters in tab title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8616 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4073 4074 +1
=======================================
+ Hits 4037 4038 +1
Misses 36 36 ☔ View full report in Codecov by Sentry. |
Member
|
@aalyahya thank you. Sorry, I won't be accepting this change. I've decided for months now that I will remove the tabs component in another v4 beta release as that was my intention. The only component that we don't use directly that will remain is panel. When the tabs component is removed, I will make sure to update the UPGRADING guide to call out that breaking change. |
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Ensure Unique Tab IDs for Non-Latin Titles
This PR fixes an issue that occurs when using non-Latin titles for tabs without specifying a custom id
Issue:
When using non-Latin titles for tabs without specifying a custom id, the generated HTML assigns duplicate id values due to
String#parameterizereturning an empty string for non-Latin characters.Example:
Generates:
Since both tabs receive the same id, tab navigation breaks.
Cause
string.parameterize ignores non-Latin characters and returns an empty string:
Fix:
If parameterize returns an empty string, we now generate a random string using
SecureRandom.hex.first(8)to ensure uniqueness. A new instance variable,@fragments, tracks generated IDs to maintain reference consistency.Changes
• Ensured unique tab id generation when parameterize results in an empty string.
• Introduced @fragments to store generated IDs.
• Added a test case to verify correctness.