Support sortable argument in id_column#8639
Merged
javierjulio merged 1 commit intoactiveadmin:masterfrom Mar 1, 2025
Merged
Conversation
jaynetics
commented
Feb 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8639 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4073 4073
=======================================
Hits 4037 4037
Misses 36 36 ☔ View full report in Codecov by Sentry. |
jaynetics
commented
Feb 26, 2025
javierjulio
approved these changes
Feb 26, 2025
Member
javierjulio
left a comment
javierjulio
left a comment
There was a problem hiding this comment.
Thanks! Only hold up here is to remove the require statements in the spec. I'll merge and get a new v4 beta release out sometime after.
This is mostly useful to prevent sorting on tables with uuid PKs. Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index.
jaynetics
force-pushed
the
support-sortable-for-id_column
branch
from
ec2a460 to
56c4953
Compare
mgrunberg
added a commit
that referenced
this pull request
Mar 6, 2025
This is mostly useful to prevent sorting on tables with uuid PKs. Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index. Backport #8639
mgrunberg
added a commit
that referenced
this pull request
Mar 6, 2025
This is mostly useful to prevent sorting on tables with uuid PKs. Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index. Backport #8639
mgrunberg
added a commit
that referenced
this pull request
Mar 8, 2025
This is mostly useful to prevent sorting on tables with uuid PKs. Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index. Backport #8639
mgrunberg
added a commit
that referenced
this pull request
Mar 8, 2025
This is mostly useful to prevent sorting on tables with uuid PKs. Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index. Backport #8639
mgrunberg
added a commit
that referenced
this pull request
Mar 8, 2025
Support sortable argument in id_column This is mostly useful to prevent sorting on tables with uuid PKs. Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index. Backport #8639
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly useful to prevent sorting on tables with uuid PKs.
Sorting by uuid isn't very useful, and it can have problematic performance if the table is very large, even if there is an index.