@tobischo despite the tab component seems to work at http://localhost:3000/admin/kitchensink, there is a legit failure in cucumber specs

Randomized with seed 55176
$ CI=1 cucumber features/show/tabs.feature:6 
Using the default profile...
.......F--------

(::) failed steps (::)

expected not to find text "tab 3" in "tab 1\ntab 3" (RSpec::Expectations::ExpectationNotMetError)
./features/step_definitions/web_steps.rb:88:in 'block in <top (required)>'
./features/step_definitions/web_steps.rb:50:in 'block (2 levels) in <top (required)>'
./features/step_definitions/web_steps.rb:7:in 'block in WithinHelpers#with_scope'
./features/step_definitions/web_steps.rb:7:in 'WithinHelpers#with_scope'
./features/step_definitions/web_steps.rb:50:in 'block in <top (required)>'
./features/step_definitions/tab_steps.rb:17:in 'block in <top (required)>'
features/show/tabs.feature:40:in `I should not see tab content "tab 3"'

Failing Scenarios:
cucumber features/show/tabs.feature:6 # Scenario: Set a method to be called on the resource as the title

I will keep investigating, but if you know the reason feel free to provide information on how to fix

@mgrunberg

The failure is related to the tab with the "emoji", it appears that this update broke compatibility with tab '🤗'

Is this something that can be fixed in activeadmin or should be reported upstream?

CI=1 cucumber features/show/tabs.feature:6 

I've tested this way

diff --git a/app/admin/kitchen_sink.rb b/app/admin/kitchen_sink.rb
index 648cf2e..c9e6ad4 100644
--- a/app/admin/kitchen_sink.rb
+++ b/app/admin/kitchen_sink.rb
@@ -55,7 +55,7 @@ ActiveAdmin.register_page "KitchenSink" do
           cite "― Oscar Wilde"
         end
       end
-      tab :third do
+      tab '☺️' do
         para "Third tab content."
       end

This is actually an issue with activeadmin and should be related to #8616

%E2%98%BA%EF%B8%8F is not a valid value for ID

Actually GitHub does the same for wiki pages, and the behavior works

Reproducible test case:

• 1.14.0 https://jsfiddle.net/tagliala/dkLa4v7e/8
• 1.14.1 https://jsfiddle.net/tagliala/dkLa4v7e/9/

Reported here: jquery/jquery-ui#2344

Admittedly, this is part of the tests I didn't run before, since it got properly triggered only when I created a PR onto my own repo as well earlier today. We are not using tabs, so it didn't effect the "production test" for us.
Will prepare that better next time - thank you for investigating.

Acknowledged as an issue, waiting for 1.14.2

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (3-0-stable@23646df). Learn more about missing BASE report.

@@              Coverage Diff              @@
##             3-0-stable    #8670   +/-   ##
=============================================
  Coverage              ?   99.19%           
=============================================
  Files                 ?      194           
  Lines                 ?     4971           
  Branches              ?        0           
=============================================
  Hits                  ?     4931           
  Misses                ?       40           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I'm going to close here for the moment. I will reopen when 1.14.2 will be released.

The effort of downgrading to 1.14.0 and adding rules to package.json is not worth it, because there are other solutions (use npm or vendor the file)

I suggest to fork and use this branch on a fork, because I may force push here or delete the branch

There seems to be a little regression against jQuery 4:

Datepicker at http://localhost:3000/admin/categories?order=name_asc

It is not being triggered after the first onfocus, it appears to me that it should be triggered twice

probably blocked again by jquery/jquery-ui#2385

But probably we can merge the same, since jQuery 4 is not supported by the current jquery-rails, and it is optional

I explained in jquery/jquery-ui#2385 why it's more an issue in code using jQuery UI, not in jQuery UI or jQuery itself.