Ignore extra bundler output when DEBUG is set#8895
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8895 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 139 139
Lines 4046 4046
=======================================
Hits 4009 4009
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tagliala
force-pushed
the
bugfix/8891-fix-bundle-show
branch
2 times, most recently
from
805516c to
7462aaa
Compare
iangreenleaf
approved these changes
Dec 30, 2025
Contributor
iangreenleaf
left a comment
iangreenleaf
left a comment
There was a problem hiding this comment.
Sure, this is working fine for me in testing.
Contributor
Author
|
Thanks for the test and have a nice new year. I'm going to close the other PR, but of course I've kept you as the author of the commit. I'll test on a windows machine (just the javascript line) and update if necessary |
Contributor
Author
|
I can confirm this works on Windows as well and fixes the issue if DEBUG is set BeforeAfter |
tagliala
force-pushed
the
bugfix/8891-fix-bundle-show
branch
2 times, most recently
from
ee2ffb4 to
56c458c
Compare
javierjulio
approved these changes
Jan 6, 2026
lib/generators/active_admin/assets/templates/tailwind.config.js
Outdated
Show resolved
Hide resolved
When the DEBUG environment variable is set (even if empty), bundler may output additional messages to stdout, such as "Found no changes, using resolution from the lockfile". This can interfere with asset compilation, as scripts expecting a single path may instead receive multiple output lines, causing path corruption. This commit adjusts the logic to always use the last line of the output from `bundle show activeadmin`, preventing such issues even if extraneous lines are present due to DEBUG or other future messaging changes. Ref: #8891
Co-authored-by: Javier Julio <[email protected]>
tagliala
force-pushed
the
bugfix/8891-fix-bundle-show
branch
from
b6b09e3 to
79ef761
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the DEBUG environment variable is set (even if empty), bundler may output additional messages to stdout, such as "Found no changes, using resolution from the lockfile". This can interfere with asset compilation, as scripts expecting a single path may instead receive multiple output lines, causing path corruption.
This commit adjusts the logic to always use the last line of the output from
bundle show activeadmin, preventing such issues even if extraneous lines are present due to DEBUG or other future messaging changes.Ref: #8891