Merged
Conversation
tagliala
force-pushed
the
feature/drop-rails-70-71
branch
from
2f23f5f to
b027856
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8908 +/- ##
==========================================
- Coverage 99.08% 99.08% -0.01%
==========================================
Files 139 139
Lines 4046 4045 -1
==========================================
- Hits 4009 4008 -1
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tagliala
force-pushed
the
feature/drop-rails-70-71
branch
from
b027856 to
6e96617
Compare
tagliala
commented
Jan 4, 2026
| value = @promise.value | ||
| # value.value due to Rails bug https://github.com/rails/rails/issues/50776 | ||
| value.respond_to?(:value) ? value.value : value | ||
| @promise.value |
Contributor
Author
There was a problem hiding this comment.
As far as I understand, this issue never landed in 7.2
However, it is hard to test against 7.2.0 in specs because of instance doubles
Ah, thanks for clarifying, I misunderstood the branch numbering.
So it sounds like...
- It is an actual regression between 7.1.2 and 7.1.3
- It's fixed by that linked PR
- It's backported to 7-1-stable branch and will be fixed in a future 7.1.4 and stay fixed in 7.2
?
(emphasis mine)
tagliala
changed the title
tagliala
added
type enhancement
type breaking change
and removed
type enhancement
labels
javierjulio
changed the title
javierjulio
changed the title
javierjulio
changed the title
Rails 7.0 and 7.1 have reached end-of-life, so maintaining compatibility no longer brings value and can complicate support for newer Rails versions. This commit also updates the test matrix to cover Node.js 24 and updates project dependencies. Ref: #8906
tagliala
force-pushed
the
feature/drop-rails-70-71
branch
from
6e96617 to
46f1c2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rails 7.0 and 7.1 have reached end-of-life, so maintaining compatibility
no longer brings value and can complicate support for newer Rails
versions.
This commit also updates the test matrix to cover Node.js 24 and updates
project dependencies.
Ref: #8906