Fix vertical spacing on has-many forms#8927
Merged
javierjulio merged 1 commit intomasterfrom Jan 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8927 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 139 139
Lines 4045 4045
=======================================
Hits 4008 4008
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
javierjulio
force-pushed
the
forms-has-many-vertical-spacing
branch
from
0be201f to
0cc5974
Compare
For consistent display with the different ways to use has-many forms, we want to add bottom margin on has-many-fields since those are the sibling elements. The space-y-* utility won't work on has-many-container (the parent of the former) because there is a hidden input element as a sibling (to track resource database id). Further, this adds a little bottom margin on the has-many-add control.
javierjulio
force-pushed
the
forms-has-many-vertical-spacing
branch
from
0cc5974 to
98e3930
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For consistent display in has-many forms, this adds a bottom margin on the
.has-many-fieldsclass since those are the sibling elements. Thespace-y-*utility won't work on the.has-many-containerclass (the parent of the former) because there is a hidden input element (when editing a saved record) as a sibling. Further, this adds a little bottom margin on the.has-many-addcontrol.