Set <select> children bg color in dark mode for Windows browsers#8933
Merged
javierjulio merged 1 commit intomasterfrom Feb 5, 2026
Merged
Set <select> children bg color in dark mode for Windows browsers#8933javierjulio merged 1 commit intomasterfrom
javierjulio merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8933 +/- ##
=======================================
Coverage 99.08% 99.08%
=======================================
Files 139 139
Lines 4045 4045
=======================================
Hits 4008 4008
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This sets an explicit background color on the select element (drop down) children to fix the display issue on Windows based browsers (e.g. Chrome) when in dark mode. This doesn't apply on Mac. For added confirmation, Tailwind does this in their example form layout for the Country drop down https://tailwindcss.com/plus/ui-blocks/application-ui/forms/form-layouts
javierjulio
force-pushed
the
select-children-bg-color-fix
branch
from
c285e9c to
0bf4cdb
Compare
javierjulio
changed the title
javierjulio
changed the title
javierjulio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets an explicit background color on the select element (drop down) children to fix the display issue on Windows based browsers (e.g. Chrome) when in dark mode. This doesn't apply on Mac. For added confirmation, Tailwind does this in their example form layout for the Country drop down https://tailwindcss.com/plus/ui-blocks/application-ui/forms/form-layouts