Remove unnecessary uses_transaction from order clause and resource specs#8962
Merged
tagliala merged 2 commits intobugfix/8881-permanent-connection-cherrypickfrom Mar 6, 2026
Merged
Conversation
The uses_transaction calls were added alongside with_connection in resource_quoted_column_name, but are not needed because: - with_connection is designed to work correctly within transactional tests - quote_column_name is a pure string operation with no DB writes - No special transaction handling is required for these tests Co-authored-by: tagliala <[email protected]>
Copilot
AI
changed the title
[WIP] Update legacy connection drop PR to address review feedback
Remove unnecessary Mar 6, 2026
uses_transaction from order clause and resource specs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bugfix/8881-permanent-connection-cherrypick #8962 +/- ##
============================================================================
Coverage 99.08% 99.08%
============================================================================
Files 139 139
Lines 4046 4046
============================================================================
Hits 4009 4009
Misses 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tagliala
merged commit b009716
into
bugfix/8881-permanent-connection-cherrypick
26 checks passed
tagliala
added a commit
that referenced
this pull request
Mar 6, 2026
…specs (#8962) * Initial plan * Remove unnecessary uses_transaction annotations from specs The uses_transaction calls were added alongside with_connection in resource_quoted_column_name, but are not needed because: - with_connection is designed to work correctly within transactional tests - quote_column_name is a pure string operation with no DB writes - No special transaction handling is required for these tests Co-authored-by: tagliala <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: tagliala <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses_transactionwas added alongside thewith_connectionmigration but is not actually needed.with_connectionworks correctly within transactional tests — it safely reuses the thread's existing checked-out connection.quote_column_nameis a pure string operation with no DB I/O, so there's no reason to opt out of the transaction wrapper.Changes
spec/unit/order_clause_spec.rb: Removeuses_transaction "#to_sql prepends table name"and its commentspec/unit/resource_spec.rb: Removeuses_transaction "should return quote argument"and its comment🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.