Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8964 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4971
Branches ? 0
=============================================
Hits ? 4931
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I've also tested this locally. Seems fine |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR backports Devise 5 compatibility by widening ActiveAdmin’s runtime Devise version guard and updating the repository’s appraisal/development gemfiles and lockfiles to exercise Devise 5 + Formtastic 6 on Rails 8.x while keeping older Rails appraisals on Devise 4.9.
Changes:
- Allow Devise 5 at runtime by widening the
ActiveAdmin::Dependency::Requirements::DEVISEconstraint to< 6. - Update Rails 8.x Gemfiles/lockfiles (and the root Gemfile/lockfile) to use Devise
~> 5.0and Formtastic>= 6.0.0. - Keep Rails 6.1–7.2 appraisals pinned to Devise
~> 4.9(and, for Rails 7.2, Formtastic~> 5.0) due to Ruby 3.1 coverage.
Reviewed changes
Copilot reviewed 7 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/active_admin/dependency.rb | Widens allowed Devise versions to include 5.x. |
| Gemfile | Pins development/test dependencies to Devise 5 and Formtastic 6 for Rails 8.1. |
| Gemfile.lock | Updates lockfile to Devise 5/Formtastic 6 (plus other resolved upgrades). |
| gemfiles/rails_80/Gemfile | Pins Rails 8.0 appraisal to Devise 5 and Formtastic 6. |
| gemfiles/rails_80/Gemfile.lock | Locks Rails 8.0 appraisal with Devise 5/Formtastic 6 (plus other resolved upgrades). |
| gemfiles/rails_72/Gemfile | Keeps Devise 4.9 and pins Formtastic ~>5.0 for Ruby 3.1 compatibility. |
| gemfiles/rails_72/Gemfile.lock | Updates Rails 7.2 appraisal lockfile and direct dependency constraints. |
| gemfiles/rails_71/Gemfile | Keeps Devise 4.9 for Rails 7.1 appraisal. |
| gemfiles/rails_71/Gemfile.lock | Updates Rails 7.1 appraisal lockfile (plus other resolved upgrades). |
| gemfiles/rails_70/Gemfile | Keeps Devise 4.9 for Rails 7.0 appraisal. |
| gemfiles/rails_70/Gemfile.lock | Updates Rails 7.0 appraisal lockfile (plus other resolved upgrades). |
| gemfiles/rails_61/Gemfile | Pins Rails 6.1 appraisal to Devise ~>4.9. |
| gemfiles/rails_61/Gemfile.lock | Updates Rails 6.1 appraisal lockfile and pins Devise ~>4.9 in dependencies. |
mgrunberg
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #8936