Handle case where returned object from a Watch is not a Pod#132
Merged
kzadorozhny merged 2 commits intoadobe:mainfrom Apr 17, 2023
Merged
Handle case where returned object from a Watch is not a Pod#132kzadorozhny merged 2 commits intoadobe:mainfrom
kzadorozhny merged 2 commits intoadobe:mainfrom
Conversation
kzadorozhny
approved these changes
Apr 17, 2023
arturo-skydio
pushed a commit
to Skydio/rules_gitops
that referenced
this pull request
Oct 5, 2023
* Handle cases where returned object from a watch is not a Pod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Watchfunction, when passed in interface ofv1.PodInterfaceassumes that the returned type is always of*corev1.Pod, this is not always the case and can result in panics. Here is a simple log of a panic that I hit:Related Issue
Motivation and Context
Fix panic.
How Has This Been Tested?
Types of changes
Checklist: