resolver: Don't crash on nil objs#142
Merged
kzadorozhny merged 1 commit intoadobe:mainfrom Aug 28, 2023
Merged
Conversation
Collaborator
|
Thanks for the contribution! Mind adding a test for this case? |
If a YAML specifies an empty `initContainers:`, this will crash this code if we also specify yamls. regardless of how pointless this is, this is, it is valid k8s yaml that applies cleanly.
DolceTriade
force-pushed
the
resolvecrash
branch
from
c2de73b to
c0cd4a2
Compare
Contributor
Author
|
Sorry I missed your comment. Added a test case that crashes on main but not on my branch. PTAL, thanks! |
michaelschiff
approved these changes
Aug 28, 2023
kzadorozhny
approved these changes
Aug 28, 2023
arturo-skydio
pushed a commit
to Skydio/rules_gitops
that referenced
this pull request
Oct 5, 2023
If a YAML specifies an empty `initContainers:`, this will crash this code if we also specify yamls. regardless of how pointless this is, this is, it is valid k8s yaml that applies cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a YAML specifies an empty
initContainers:, this will crash this code if we also specify yamls. regardless of how pointless this is, this is, it is valid k8s yaml that applies cleanly.Related Issue
Fix #141
Motivation and Context
Fixes crash
How Has This Been Tested?
No longer crashes
Types of changes
Checklist: