Merged
Conversation
if an account module visibility is also expected
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
=======================================
Coverage 81.39% 81.40%
=======================================
Files 163 163
Lines 12234 12176 -58
=======================================
- Hits 9958 9912 -46
+ Misses 2276 2264 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Marc-Andrieu
approved these changes
May 11, 2025
Member
Marc-Andrieu
left a comment
Marc-Andrieu
left a comment
There was a problem hiding this comment.
I approve because we need this PR and I've reviewed 43/46 files, but still don't get these two last changes :
app/core/core_endpoints/endpoints_core.py: why remove the try-except block and the HTTP exception?- why remove the parentheses after
@pytest.fixture?
Member
|
Update: I got my answers |
armanddidierjean
added
dependencies
# Conflicts: # tests/test_payment.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump Ruff. Enable new rules