Move versions declaration in pyproject.toml#700
Merged
Marc-Andrieu merged 8 commits intomainfrom Jun 1, 2025
Merged
Conversation
Marc-Andrieu
added
help wanted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
+ Coverage 81.38% 81.40% +0.02%
==========================================
Files 163 163
Lines 12218 12232 +14
==========================================
+ Hits 9944 9958 +14
Misses 2274 2274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
The workflow fails because we're still using Ruff 0.5 and it needs Ruff >=0.8 : astral-sh/ruff#13869 (comment) So I'm going to need #697 |
Marc-Andrieu
force-pushed
the
version-declaration
branch
from
e543d43 to
b9489c3
Compare
Marc-Andrieu
force-pushed
the
version-declaration
branch
from
9a9688a to
1592b27
Compare
# Conflicts: # app/core/utils/config.py
Marc-Andrieu
force-pushed
the
version-declaration
branch
from
23cf566 to
f6cedcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
How
toml_file="pyproject.toml",in theSettingsConfigDict(line 49) so that the model would load fields from both config files (.envandpyproject.toml), but it seems Pydantic does not allow that at all...tomllibTOML parser : it the only solution that worked for me, and it's short.withis out of the class because Pydantic started crying about the type of the bytes flow from reading the file)pyproject.tomlto the
[project]table, but I realized it didn't even exist, so I ended up writing the bare minimum.