Skip to content

Correct index for association members reorder#642

Closed
Rotheem wants to merge 1 commit intomainfrom
fix-association-member-sort
Closed

Correct index for association members reorder#642
Rotheem wants to merge 1 commit intomainfrom
fix-association-member-sort

Conversation

@Rotheem
Copy link
Member

@Rotheem Rotheem commented Jan 27, 2026

Description

Summary

...

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • ...
  • ...

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.88%. Comparing base (36e8580) to head (a5454f7).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #642   +/-   ##
=======================================
  Coverage   50.88%   50.88%           
=======================================
  Files         167      167           
  Lines        3797     3797           
=======================================
  Hits         1932     1932           
  Misses       1865     1865

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu force-pushed the fix-association-member-sort branch from b9dacc1 to 965b0fd Compare January 28, 2026 14:02
@Marc-Andrieu Marc-Andrieu force-pushed the fix-association-member-sort branch from 965b0fd to a5454f7 Compare January 30, 2026 14:01
@Marc-Andrieu
Copy link
Member

Marc-Andrieu commented Jan 30, 2026

Doesn't work actually

@Marc-Andrieu
Copy link
Member

Marc-Andrieu commented Jan 30, 2026

Superseded by #644

@Marc-Andrieu Marc-Andrieu mentioned this pull request Jan 30, 2026
Merged
19 tasks
@Marc-Andrieu Marc-Andrieu deleted the fix-association-member-sort branch January 30, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Marc-Andrieu Marc-Andrieu Marc-Andrieu approved these changes

@FastSpyder FastSpyder FastSpyder approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Rotheem @codecov-commenter @Marc-Andrieu @FastSpyder