Merged
Conversation
Marc-Andrieu
added
ready for review
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
=======================================
Coverage 50.88% 50.88%
=======================================
Files 167 167
Lines 3797 3797
=======================================
Hits 1932 1932
Misses 1865 1865 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Mar 6, 2026
Marc-Andrieu
force-pushed
the
update/flutter-3-41
branch
from
66d0e78 to
6916617
Compare
Rotheem
approved these changes
Mar 13, 2026
Rausterr
approved these changes
Mar 13, 2026
Marc-Andrieu
added a commit
that referenced
this pull request
Mar 14, 2026
# Description ## Summary <!--BRIEF description: DON'T EXPLAIN the code: JUSTIFY what this PR is for!--> The current index.html has been obsolete for the past 2 years! Cf. the official example - https://github.com/flutter/flutter/blob/stable/examples/api/web/index.html - then blame to see flutter/flutter#152349: the index.html before this 2024 PR has exactly the outdated script we still use today. The current index.html script explicitly runs a JS file, and unlike the new one, does not support WASM builds. Like #660, I chose to bump the version here in a dedicated PR instead - for testing purposes (the app works just as before) - so no-one complains the PR does too much at a time ## Changes Made <!--DESCRIBE the changes: tell the BIG STEPS, use a CHECKLIST to show progress. You can explain below how the code works.--> - [x] Rewrite the index.html - [x] Use the new script and test again (see the PoC at #646) - [x] Some fixes in the `<head>` tag: two title tags, use new `mobile-web-app-capable` meta (without `apple-` prefix, etc ## Additional Notes <!--Anything relevant that does not quite fit in the summary--> <!--Don't touch these two tags--> <details> <summary> # Classification </summary> ## Type of Change - [x] 🐛 Bug fix (non-breaking change which fixes an issue) - [ ] ✨ New feature (non-breaking change which adds functionality) - [x] 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature) - [ ] 🔧 Infra CI/CD (changes to configs of workflows) - [ ] 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end) - [x] 😶🌫️ No impact for the end-users ## Impact & Scope - [ ] Core functionality changes - [ ] Single module changes - [ ] Multiple modules changes - [x] Other: web/ directory <!--Not module-oriented: write something!--> ## Testing - [x] 1. Tested this locally - [ ] 2. Added/modified tests that pass the CI (or tested in a downstream fork) - [x] 3. Tested in a local client using a pre-prod backend - [ ] 0. Untestable (exceptionally), will be tested in prod directly ## Documentation - [ ] Updated [the docs](docs.myecl.fr) accordingly : <!--[Docs#0 - Title](https://github.com/aeecleclair/myecl-documentation/pull/0)--> - [ ] `//` Comments - [x] No documentation needed </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Flutter 3.41 is out there.
(I'm going to need it for the new dev flag to disable cross-origin isolation in WASM builds.)
Anyway, I chose to bump the version here in a dedicated PR instead
Changes Made
Additional Notes
Classification
Type of Change
Impact & Scope
Testing
Documentation
//Comments