Skip to content

Rewrite(web): new default generic index.html#661

Merged
Marc-Andrieu merged 1 commit intomainfrom
rewrite/web/index-html
Mar 14, 2026
Merged

Rewrite(web): new default generic index.html#661
Marc-Andrieu merged 1 commit intomainfrom
rewrite/web/index-html

Conversation

@Marc-Andrieu
Copy link
Member

Description

Summary

The current index.html has been obsolete for the past 2 years!

Cf. the official example

The current index.html script explicitly runs a JS file, and unlike the new one, does not support WASM builds.

Like #660, I chose to bump the version here in a dedicated PR instead

  • for testing purposes (the app works just as before)
  • so no-one complains the PR does too much at a time

Changes Made

  • Rewrite the index.html
    • Use the new script and test again (see the PoC at Load the web version faster #646)
    • Some fixes in the <head> tag: two title tags, use new mobile-web-app-capable meta (without apple- prefix, etc

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Other: web/ directory

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a local client using a pre-prod backend
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • // Comments
  • No documentation needed

@Marc-Andrieu Marc-Andrieu self-assigned this Mar 6, 2026
@Marc-Andrieu Marc-Andrieu added ready for review This PR is ready to be reviewed fix bug This PR fix a bug web labels Mar 6, 2026
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.88%. Comparing base (3831d73) to head (e63207a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   50.88%   50.88%           
=======================================
  Files         167      167           
  Lines        3797     3797           
=======================================
  Hits         1932     1932           
  Misses       1865     1865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marc-Andrieu Marc-Andrieu mentioned this pull request Mar 7, 2026
25 tasks
@Marc-Andrieu Marc-Andrieu force-pushed the rewrite/web/index-html branch from f58dad2 to 5e41710 Compare March 13, 2026 10:13
@Marc-Andrieu Marc-Andrieu force-pushed the rewrite/web/index-html branch from 5e41710 to e63207a Compare March 14, 2026 08:38
@Marc-Andrieu Marc-Andrieu merged commit 62f43a4 into main Mar 14, 2026
3 checks passed
@Marc-Andrieu Marc-Andrieu deleted the rewrite/web/index-html branch March 14, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix bug This PR fix a bug ready for review This PR is ready to be reviewed web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants