feat!: remove generate_header capability#514
Merged
aherrmann merged 3 commits intoaherrmann:mainfrom Sep 10, 2025
Merged
Conversation
emit-h is broken and there has been no progress towards a fix since more than year. Making this PR as a standalone one so that we can easily revert when emit-h is fixed.
cerisier
force-pushed
the
cerisier/remove-emit-h
branch
from
9e3a325 to
f2101f6
Compare
Given that the `:zig_header` target itself still remains, it makes sense to still document it in the BUILD file.
aherrmann
approved these changes
Sep 10, 2025
Owner
aherrmann
left a comment
aherrmann
left a comment
There was a problem hiding this comment.
Looks good, thank you! I've partly reinstated the zig-header doc string, since the target itself is still there, and just removed the -femit-h bits.
Contributor
Author
|
My bad thanks ! |
aherrmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, emit-h is broken and there has been no progress towards a fix since more than year.
Making this PR as a standalone one so that we can easily revert when emit-h is fixed.