Merged
Conversation
aherrmann
reviewed
Sep 25, 2025
Owner
aherrmann
left a comment
aherrmann
left a comment
There was a problem hiding this comment.
Thank you, that's great!
Would it be possible to add an integration test for this feature?
Contributor
Author
|
Done ! |
By emitting and parsing the build event stream from Bazel and forcing a fetch by disabling the repository cache and remote asset API.
aherrmann
approved these changes
Sep 28, 2025
Owner
aherrmann
left a comment
aherrmann
left a comment
There was a problem hiding this comment.
Thank you, looks good!
I've changed it to make the urls attribute mandatory, mirrors don't really make sense without.
And I've expanded the integration test. Before it didn't actually fail if the mirrors feature was broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is encouraged by the Zig documentation to use mirrors to download the Zig toolchain since they moved to self hosting.
See https://ziglang.org/news/migrate-to-self-hosting/
See https://ziglang.org/download/community-mirrors/
This PR adds the ability to the zig extension.