Change label for email address facets and statistics to remove ambiguity#3671
Merged
tillprochaska merged 1 commit intodevelopfrom Apr 4, 2024
Merged
Change label for email address facets and statistics to remove ambiguity#3671tillprochaska merged 1 commit intodevelopfrom
tillprochaska merged 1 commit intodevelopfrom
Conversation
Previously, the label for both email addresses and email entities was "Email" which could be confusing when both were displayed next to each other (for example on the dataset overview screen). Fixes #3668
tillprochaska
force-pushed
the
fix/3668-ambiguous-labels
branch
from
47b1ce0 to
c4e4336
Compare
Rosencrantz
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the label for both email addresses and email entities was "Email" which could be confusing when both were displayed next to each other (for example on the dataset overview screen).
I’ve also updated the spelling from "E-Mail" to "Email" which seems to be the prevalent spelling of the term nowadays (and in other places in the UI).
Fixes #3668