Remove references to convert-document#3681
Remove references to convert-document#3681stchris merged 2 commits intoalephdata:developfrom friendly-wolfbat:develop
Conversation
stchris
left a comment
There was a problem hiding this comment.
I left a few remarks, thanks for cleaning this up!
|
Thanks so much for reviewing. I believe I made all the changes requested. A couple of unrelated things I noticed:
|
|
Thanks for your changes, I will review them shortly!
Ah yes, good observation. I believe for consistency we should do this in a separate PR across all of our documentation.
Another good observation. So if one uses our Helm chart everything would be prefixed with |
|
Thanks for your contribution, @friendly-wolfbat |
|
@stchris Hey, I'm sorry, it looks like the hyperlink I had to the installation page is wrong, when looking at the "Checks" tab. Should I have put a slash before the hashtag? |
|
Don't worry about it, @friendly-wolfbat ! It is our fault because there need to be some CI checks on PRs which are currently not in place. I will take care of fixing it. |
Per #3680 (comment), I am attempting a pull request to remove references to the old
convert-documentcontainer, which has since been consolidated intoingest-file(see #2755).This is my first pull request and I am open to learning! Please let me know if anything is wrong or if I need to make any adjustments.