Merged
Conversation
When we first implemented bookmarks as an experimental feature, they were stored in local storage. People started using the feature so we decided to continue working on bookmarks to build it out into a mature feature. Most importantly, this included storing bookmarks on the server-side in order to support growing numbers of bookmarks per user and to prevent users from losing their bookmarks when clearing browsing data/switching devices. We also needed to migrate bookmarks that were currently stored locally to the server side. That means the code base had quite some code that only handled migrating the "legacy" local bookmarks to the server. As it’s been a while since we started migrating to server-side bookmarks, it should be safe to remove that migration logic now. Fix #2864
tillprochaska
force-pushed
the
2864-remove-bookmarks-migration
branch
from
67f1a06 to
5b8e3d2
Compare
Rosencrantz
reviewed
May 29, 2024
Contributor
Rosencrantz
left a comment
Rosencrantz
left a comment
There was a problem hiding this comment.
This is the most baller pull request I have ever seen
Rosencrantz
approved these changes
May 29, 2024
catileptic
approved these changes
May 29, 2024
Contributor
catileptic
left a comment
catileptic
left a comment
There was a problem hiding this comment.
LGTM :) great work, thank you for returning to this code and removing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we first implemented bookmarks as an experimental feature, they were stored in local storage. People started using the feature so we decided to continue working on bookmarks to build it out into a mature feature.
Most importantly, this included storing bookmarks on the server-side in order to support growing numbers of bookmarks per user and to prevent users from losing their bookmarks when clearing browsing data/switching devices.
We also needed to migrate bookmarks that were currently stored locally to the server side. That means the code base had quite some code that only handled migrating the "legacy" local bookmarks to the server. As it’s been a while since we started migrating to server-side bookmarks, it should be safe to remove that migration logic now.
Fix #2864