Implement infinite scrolling for document search#3855
Merged
tillprochaska merged 4 commits intodevelopfrom Oct 16, 2024
Merged
Conversation
This is just a small refactoring to make it easier to adjust this method.
… because that is what it actually does -- it doesn’t load a page from the document, it loads a list of pages that contain the search terms.
I’m not sure what exactly the intention here was originally, but it didn’t have any effect in its current version. `page` and `res.index` would always be undefined and as a result, the `active` class was applied to every single link. The `active` class doesn’t apply any styles. Probably this is just leftover from a previous iteration of the UI, so I’ve removed this.
tillprochaska
requested review from
catileptic and
stchris
and removed request for
Rosencrantz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching a large document in a dataset which has a significant number of results, only the first set of results are shown.
I’ve fixed this by implementing infinite scrolling in the same way we already implement this for other views (such as the main search view). Now, when a user has scrolled to the end of the search results list and if there are more results, the next page of results is automatically loaded.
In addition, I’ve used the opportunity to do some cleanup and remove dead code from the component responsible for displaying document search results.