Multiple small UX enhancements related to investigation sharing/user suggestion component#3868
Merged
tillprochaska merged 5 commits intorelease/4.0.0from Sep 24, 2024
Conversation
We’ve recently updated this in the backend, but hadn’t yet updated the frontend.
Previously, after you cleared the input field, the component would still display suggestions for the previous input value until the user typed at least 5 chars (the min prefix length).
…tization This automatically sanitizes the entered value by removing leading and trailing whitespace. When copy-pasting email addresses, it commonly happens that the copy-pasted text includes leading or trailing whitespace.
tillprochaska
force-pushed
the
fix/investigation-share-email-normalization
branch
from
1a8ac4c to
5b6b0ad
Compare
stchris
approved these changes
Sep 24, 2024
Contributor
stchris
left a comment
stchris
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks for the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few small UX bugs related to investigation sharing and user suggestions:
[email protected](leading whitespace) or[email protected]wouldn’t match[email protected].