Add test to cover last_login_at timestamp in OAuth workflow#3878
Merged
tillprochaska merged 2 commits intodevelopfrom Oct 15, 2024
Merged
Add test to cover last_login_at timestamp in OAuth workflow#3878tillprochaska merged 2 commits intodevelopfrom
last_login_at timestamp in OAuth workflow#3878tillprochaska merged 2 commits intodevelopfrom
Conversation
This is a follow-up to #3852. This PR above didn’t include a test for the expected behavior when logging in via OAuth. There have been a lot of changes to authentication testing on the develop branch that were not present in the 4.0 release branch, so any changes would have lead to annoying merge conflicts down the line. But now that the 4.0 release is integrated, it’s time to add a proper test :)
This was an oversight and should have always called `super().setUp()` instead of `super().setUpClass()`. This didn’t fail when running tests for the entire file (`pytest test_sessions_api.py`), but it did always fail when running individual tests (`pytest test_sessions_api.py -k oauth_callback`).
stchris
approved these changes
Oct 15, 2024
Contributor
stchris
left a comment
stchris
left a comment
There was a problem hiding this comment.
Ah, thanks for coming back to add this. Much appreciated, Till!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #3852. This PR above didn’t include a test for the expected behavior when logging in via OAuth. There have been a lot of changes to authentication testing on the develop branch that were not present in the 4.0 release branch, so any changes would have lead to annoying merge conflicts down the line.
But now that the 4.0 release is integrated, it’s time to add a proper test :)