Update Prometheus exporter probes so they do not actually generate all metrics#3996
Merged
tillprochaska merged 2 commits intodevelopfrom Nov 7, 2024
Merged
Update Prometheus exporter probes so they do not actually generate all metrics#3996tillprochaska merged 2 commits intodevelopfrom
tillprochaska merged 2 commits intodevelopfrom
Conversation
…l metrics Generating all metrics can take multiple seconds for large Aleph instances, which can make the liveness/readiness probe fail. The `name[]` query parameter can be used to select a subset of metrics the exporter should return (or no metrics as all in this case). That way, we can check that the exporter is up and running without actually generating any metrics.
This should be a little closer to real-world usage
tillprochaska
force-pushed
the
fix/exporter-probes
branch
from
72e52a7 to
ff49219
Compare
stchris
approved these changes
Nov 7, 2024
Contributor
stchris
left a comment
stchris
left a comment
There was a problem hiding this comment.
Sounds sensible to me. Thanks for figuring it out and fixing it! 🚀
catileptic
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating all metrics can take multiple seconds for large Aleph instances, which can make the liveness/readiness probe fail. The
name[]query parameter can be used to select a subset of metrics the exporter should return (or no metrics as all in this case). That way, we can check that the exporter is up and running without actually generating any metrics.