Update AndroidManifest.java#1491
Update AndroidManifest.java#1491amatsegor wants to merge 1 commit intoandroidannotations:developfrom amatsegor:patch-1
Conversation
|
Nice catch! Thanks. This line was broken by 2ee251d#diff-d29654a60dfa65217895cded5ca1943eR50. This property is not used currently, but would cause troubles in the future. BTW, can you ask you to reword the commit as to add a more descriptive commit message per the contribution guidelines? Also, next time please use a proper branch name! (I know you just edited the file with the GitHub editor now.) |
|
Yep, you're right) Visited your project repo for the first time, chose a random file just to see how the framework works, found the problem and fixed it) |
|
Yeah, thanks for keeping to the boy scout rule! We welcome any contributions, from a typo fix to a big refactor. No worries, and thanks! ;) |
|
Can you rebase this branch onto develop? |
|
Merged as of 314fbec. |
Fix of an assignment of the parameter to itself instead of the class field.