Closed
Conversation
claincly
approved these changes
Jul 8, 2022
Contributor
claincly
left a comment
claincly
left a comment
There was a problem hiding this comment.
Looks good overall, merging internally.
claincly
reviewed
Jul 8, 2022
...ies/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/reader/RtpVp8ReaderTest.java
Outdated
Show resolved
Hide resolved
Set the fixed clock rate in VP8 Reader Test Change-Id: I0bdedc803bb892d93fde2a027a01cb49a48597ef
claincly
reviewed
Jul 13, 2022
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVp8Reader.java
Outdated
Show resolved
Hide resolved
rohitjoins
added a commit
that referenced
this pull request
Jul 13, 2022
PiperOrigin-RevId: 460513413
Reset fragmentedSampleSizeBytes to LENGTH_UNSET. Change-Id: Ie8a66702a7e26b5e240a7163dac6343531f1b49f
Contributor
Author
|
The merge commit 9d9bbe3, addresses the two review comments. We can skip these 2 commits. |
rohitjoins
added a commit
that referenced
this pull request
Jul 15, 2022
PiperOrigin-RevId: 460513413 (cherry picked from commit 9d9bbe3)
Contributor
|
Thanks for making the change. Could you create a new PR for the two recent commits, as the original PR is already merged into |
Contributor
Author
|
The review comments addressed in the recent two commits are already resolved in commit 9d9bbe3 and merged on main. We can discard the recent two commits. |
marcbaechinger
pushed a commit
that referenced
this pull request
Sep 30, 2022
PiperOrigin-RevId: 460513413 (cherry picked from commit c75b6a3)
marcbaechinger
pushed a commit
that referenced
this pull request
Sep 30, 2022
PiperOrigin-RevId: 460513413
ldm0206
pushed a commit
to mytv-android/media
that referenced
this pull request
Oct 21, 2025
fix: BRANCH_NAME
Contributor
|
Already merged: internal 460513413 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exoplayer RTP VP8 Reader had few issues.
Created a issue describing the same.
Fixed the reported issue in the PR and added RTP VP8 tests as well.