Make download notification appear immediately#183
Merged
rohitjoins merged 1 commit intoandroidx:mainfrom Oct 24, 2022
Merged
Conversation
microkatz
pushed a commit
that referenced
this pull request
Nov 22, 2022
…ation-appear-immediately PiperOrigin-RevId: 482165983 (cherry picked from commit 1565a2d)
icbaker
pushed a commit
that referenced
this pull request
Nov 24, 2022
…ation-appear-immediately PiperOrigin-RevId: 482165983
icbaker
pushed a commit
that referenced
this pull request
Dec 12, 2022
…ation-appear-immediately PiperOrigin-RevId: 482165983 (cherry picked from commit 405455b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Android 12 (API 31) notifications produced by
startForegroundmethod wait 10 seconds until showing. This could be confusing to user who useDownloadNotificationHelpermethods to build notifications to show in a customDownloadService(protected abstract Notification getForegroundNotification(List<Download> downloads, @RequirementFlags int notMetRequirements);).Docs excerpt:
To make the notifications be shown immediately once actual download operation is started,
FOREGROUND_SERVICE_IMMEDIATEcan be set toNotificationCompat.Builder.setForegroundServiceBehavior().See: https://developer.android.com/guide/components/foreground-services#notification-immediate