Closed
Conversation
Change-Id: Id658564495af13c35fa78ecde9ab587557aabb47
claincly
requested changes
Apr 11, 2022
Contributor
claincly
left a comment
claincly
left a comment
There was a problem hiding this comment.
Please also rebase to the newest head in main
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/RtspMediaTrack.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Outdated
Show resolved
Hide resolved
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Outdated
Show resolved
Hide resolved
Change-Id: I7e2d36eb3d69fb09e0d0bbc283d41165c69d4076
Contributor
|
looks good, will start merging process internally |
claincly
reviewed
May 9, 2022
| fragmentedSampleSizeBytes = 0; | ||
| gotFirstPacketOfVP9Frame = false; | ||
| } | ||
| previousSequenceNumber = sequenceNumber; |
Contributor
There was a problem hiding this comment.
can you check if moving this line to out of the if (validateVp9Descriptor(data, sequenceNumber)) works? i.e. move it down one line.
Contributor
Author
There was a problem hiding this comment.
By moving "previousSequenceNumber = sequenceNumber;" down, packet(s) with Invalid Payload Descriptor will also get logged in previousSequenceNumber which can lead to directly get follow-on packet without start Code packet.
claincly
reviewed
May 9, 2022
libraries/exoplayer_rtsp/src/main/java/androidx/media3/exoplayer/rtsp/reader/RtpVP9Reader.java
Show resolved
Hide resolved
Change-Id: I92d6d7c539d05b74f83a76fdb8c6691f6c45f48d
marcbaechinger
pushed a commit
that referenced
this pull request
Jun 14, 2022
PiperOrigin-RevId: 448978892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Id658564495af13c35fa78ecde9ab587557aabb47