Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

I signed it!

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@MansourFall Can you update the commit message with feat(common): HttpParams fromObject accepts ReadonlyArray<string> please?

@cexbrayat update done! thanks!

@MansourFall Would you mind rebasing the PR to resolve the conflict? Basically keeping the new signature, but with the updated comment:

/** Object map of the HTTP parameters. Mutually exclusive with `fromString`. */
fromObject?: {[param: string]: string | ReadonlyArray<string>};

To do so:

git fetch upstream
git rebase upstream/master
# resolve the conflict
git add packages/common/http/src/params.ts
git rebase --continue
# check if everything is OK
git show
# all good? ready to push!
git push --force

When that's done we should be able to merge it!

@cexbrayat thank you for the instructions, just made the changes!

Presubmit = http://test/OCL:266428477:BASE:266428502:1567191852249:433a52b0

Ivy Presubmit = http://test/OCL:266428477:BASE:266428670:1567191897180:bf41ddb3

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}