Skip to content

fix(animations): fix incorrect handling of camel-case css properties#48436

Closed
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:animations-kebab-case-prop-bugfix
Closed

fix(animations): fix incorrect handling of camel-case css properties#48436
dario-piotrowicz wants to merge 1 commit intoangular:mainfrom
dario-piotrowicz:animations-kebab-case-prop-bugfix

Conversation

@dario-piotrowicz
Copy link
Contributor

fix the issue of camel-case properties not being handled correctly in state transition causing them not to be applied to the element

resolves #48246

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

CSS kebab-case properties are not correctly handled in state transitions (whilst camelCase ones are)

for example:
before

What is the new behavior?

CSS kebab-case properties are correctly handled, consistently as the camelCase ones

for example:
after

Does this PR introduce a breaking change?

  • Yes
  • No

@pullapprove pullapprove bot requested a review from alxhub December 10, 2022 19:47
fix the issue of camel-case properties not being handled correctly in
state transition causing them not to be applied to the element

resolves angular#48246
@dario-piotrowicz dario-piotrowicz force-pushed the animations-kebab-case-prop-bugfix branch from e0a45cf to 03fe696 Compare December 10, 2022 20:00
@ngbot ngbot bot added this to the Backlog milestone Dec 12, 2022
@jessicajaniuk jessicajaniuk requested review from jessicajaniuk and removed request for alxhub December 12, 2022 23:05
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @dario-piotrowicz!

@jessicajaniuk jessicajaniuk added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 12, 2022
@ngbot
Copy link

ngbot bot commented Dec 12, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "google-internal-tests" is failing
    pending status "ci/circleci: legacy-unit-tests-saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jessicajaniuk jessicajaniuk added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Dec 12, 2022
@jessicajaniuk
Copy link
Contributor

Caretaker note: the failing google status is an unrelated failure

@jessicajaniuk
Copy link
Contributor

This PR was merged into the repository by commit c864845.

jessicajaniuk pushed a commit that referenced this pull request Dec 12, 2022
…48436)

fix the issue of camel-case properties not being handled correctly in
state transition causing them not to be applied to the element

resolves #48246

PR Close #48436
@dario-piotrowicz dario-piotrowicz deleted the animations-kebab-case-prop-bugfix branch December 13, 2022 00:08
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Dec 23, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fanimations/15.0.2/15.0.4) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcommon/15.0.2/15.0.4) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/15.0.2/15.0.4) |
| [@angular/compiler-cli](https://github.com/angular/angular/tree/main/packages/compiler-cli) ([source](https://github.com/angular/angular)) | devDependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/15.0.2/15.0.4) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcore/15.0.2/15.0.4) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fforms/15.0.2/15.0.4) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/15.0.2/15.0.4) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`15.0.2` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/15.0.2/15.0.4) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v15.0.4`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1504-2022-12-14)

[Compare Source](angular/angular@15.0.3...15.0.4)

##### animations

| Commit | Type | Description |
| -- | -- | -- |
| [6c1064c72f](angular/angular@6c1064c) | fix | fix incorrect handling of camel-case css properties ([#&#8203;48436](angular/angular#48436)) |

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [f30d18a942](angular/angular@f30d18a) | fix | Fix TestBed.overrideProvider type to include multi ([#&#8203;48424](angular/angular#48424)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [b55d2dab5d](angular/angular@b55d2da) | fix | evaluate const tuple types statically ([#&#8203;48091](angular/angular#48091)) |

#### Special Thanks

Alan Agius, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, BrowserPerson, Jens, Jessica Janiuk, Joey Perrott, JoostK, Konstantin Kharitonov, Lukas Matta, Piotr Kowalski, Virginia Dooley, Yannick Baron, dario-piotrowicz, lsst25, piyush132000 and why520crazy

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.0.3`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1503-2022-12-07)

[Compare Source](angular/angular@15.0.2...15.0.3)

##### common

| Commit | Type | Description |
| -- | -- | -- |
| [50b1c2bf52](angular/angular@50b1c2b) | fix | Don't generate srcsets with very large sources ([#&#8203;47997](angular/angular#47997)) |
| [bf44dc234a](angular/angular@bf44dc2) | fix | Update `Location` to support base href containing `origin` ([#&#8203;48327](angular/angular#48327)) |

##### compiler

| Commit | Type | Description |
| -- | -- | -- |
| [9a5d84249a](angular/angular@9a5d842) | fix | make sure selectors inside container queries are correctly scoped ([#&#8203;48353](angular/angular#48353)) |

##### compiler-cli

| Commit | Type | Description |
| -- | -- | -- |
| [167bc0d163](angular/angular@167bc0d) | fix | Produce diagnostic rather than crash when using invalid hostDirective ([#&#8203;48314](angular/angular#48314)) |

##### core

| Commit | Type | Description |
| -- | -- | -- |
| [e4dcaa513e](angular/angular@e4dcaa5) | fix | unable to inject ChangeDetectorRef inside host directives ([#&#8203;48355](angular/angular#48355)) |

#### Special Thanks

Alan Agius, Alex Castle, Andrew Kushnir, Andrew Scott, Bob Watson, Derek Cormier, Joey Perrott, Konstantin Kharitonov, Kristiyan Kostadinov, Paul Gschwendtner, Pawel Kozlowski, dario-piotrowicz and piyush132000

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC43MC4wIiwidXBkYXRlZEluVmVyIjoiMzQuNzAuNCJ9-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1684
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 13, 2023
trekladyone pushed a commit to trekladyone/angular that referenced this pull request Feb 1, 2023
…ngular#48436)

fix the issue of camel-case properties not being handled correctly in
state transition causing them not to be applied to the element

resolves angular#48246

PR Close angular#48436
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: animations merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Angular animations: the style() function doesn't change property unless it's in camel case

2 participants