Skip to content

feat(bazel): (APF) Angular Package Format updates#49332

Closed
alan-agius4 wants to merge 6 commits intoangular:mainfrom
alan-agius4:ng-packagr-es2022
Closed

feat(bazel): (APF) Angular Package Format updates#49332
alan-agius4 wants to merge 6 commits intoangular:mainfrom
alan-agius4:ng-packagr-es2022

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Mar 6, 2023

Several updates to Angular Package Format.

BREAKING CHANGE:

Several changes to the Angular Package Format (APF)

  • Removal of FESM2015
  • Replacing ES2020 with ES2022
  • Replacing FESM2020 with FESM2022

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit labels Mar 6, 2023
@alan-agius4 alan-agius4 force-pushed the ng-packagr-es2022 branch 4 times, most recently from 0649546 to 6e95547 Compare March 6, 2023 12:58
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release area: bazel Issues related to the published `@angular/bazel` build rules labels Mar 6, 2023
@ngbot ngbot bot added this to the Backlog milestone Mar 6, 2023
@itea-dev

This comment was marked as resolved.

@alan-agius4 alan-agius4 force-pushed the ng-packagr-es2022 branch 3 times, most recently from ac17d27 to f1a49d3 Compare March 9, 2023 09:52
@alan-agius4 alan-agius4 force-pushed the ng-packagr-es2022 branch 3 times, most recently from 355aa08 to 725e3d2 Compare March 9, 2023 11:30
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 9, 2023
@alan-agius4 alan-agius4 force-pushed the ng-packagr-es2022 branch 3 times, most recently from 19cf38e to 4da1ef5 Compare March 9, 2023 12:21
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

Deployed aio for 4da1ef5d906e91af9a9ee3656384560599a32425 to: https://ng-dev-previews-fw--pr-angular-angular-49332-7raw2mtw.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@alan-agius4 alan-agius4 force-pushed the ng-packagr-es2022 branch 3 times, most recently from 4f19479 to b996ecb Compare March 15, 2023 11:15
@alan-agius4 alan-agius4 requested a review from devversion March 15, 2023 13:28
@pullapprove pullapprove bot requested review from AndrewKushnir and atscott March 21, 2023 19:50
@AndrewKushnir AndrewKushnir removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 21, 2023
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

(FYI the file affected public API: aio/content/guide/angular-package-format.md)

@pullapprove pullapprove bot requested a review from dylhunn March 21, 2023 19:56
Copy link
Member

@alxhub alxhub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed-for: public-api

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 21, 2023
@atscott
Copy link
Contributor

atscott commented Mar 22, 2023

This PR was merged into the repository by commit 132c00c.

@atscott atscott closed this in 842d569 Mar 22, 2023
atscott pushed a commit that referenced this pull request Mar 22, 2023
This commit updates parts of the FW to be ES2022 complaint.

These changes are needed to fix the following problems problems with using properties before they are initialized.

Example
```ts
class Foo {
   bar = this.buz;
   constructor(private buz: unknown){}
}
```

PR Close #49332
atscott pushed a commit that referenced this pull request Mar 22, 2023
google-closure-compiler does not support ES2022

(cherry picked from commit 54365418bb8388ffa9b6388ae438e4d6ac4e081d)

PR Close #49332
atscott pushed a commit that referenced this pull request Mar 22, 2023
These are currently broken due to the APF v16 changes which dropped support for ES2015.

PR Close #49332
atscott pushed a commit that referenced this pull request Mar 22, 2023
This commit patches `ts_library` to be able to produce `ES2022`. Also, updates the build tsconfig and sets `useDefineForClassFields` to `false` to keep the same behaviour of `ng_module`.

PR Close #49332
atscott pushed a commit that referenced this pull request Mar 22, 2023
Benchpress requires a decent amount of work to be ES2022 compliant. This will be done in a followup PR.

PR Close #49332
@alan-agius4 alan-agius4 deleted the ng-packagr-es2022 branch March 22, 2023 21:04
atscott added a commit to atscott/angular that referenced this pull request Mar 22, 2023
atscott added a commit to atscott/angular that referenced this pull request Mar 22, 2023
atscott added a commit to atscott/angular that referenced this pull request Mar 22, 2023
atscott added a commit to atscott/angular that referenced this pull request Mar 22, 2023
atscott added a commit to atscott/angular that referenced this pull request Mar 22, 2023
atscott added a commit that referenced this pull request Mar 22, 2023
atscott added a commit that referenced this pull request Mar 22, 2023
atscott added a commit that referenced this pull request Mar 22, 2023
atscott added a commit that referenced this pull request Mar 22, 2023
atscott added a commit that referenced this pull request Mar 22, 2023
@alan-agius4 alan-agius4 mentioned this pull request Mar 23, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules area: build & ci Related the build and CI infrastructure of the project detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants