feat(bazel): (APF) Angular Package Format updates#49332
Closed
alan-agius4 wants to merge 6 commits intoangular:mainfrom
Closed
feat(bazel): (APF) Angular Package Format updates#49332alan-agius4 wants to merge 6 commits intoangular:mainfrom
alan-agius4 wants to merge 6 commits intoangular:mainfrom
Conversation
0649546 to
6e95547
Compare
6e95547 to
da5ec2c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ac17d27 to
f1a49d3
Compare
355aa08 to
725e3d2
Compare
19cf38e to
4da1ef5
Compare
|
Deployed aio for 4da1ef5d906e91af9a9ee3656384560599a32425 to: https://ng-dev-previews-fw--pr-angular-angular-49332-7raw2mtw.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
4f19479 to
b996ecb
Compare
AndrewKushnir
approved these changes
Mar 21, 2023
Contributor
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api
(FYI the file affected public API: aio/content/guide/angular-package-format.md)
Contributor
|
This PR was merged into the repository by commit 132c00c. |
atscott
pushed a commit
that referenced
this pull request
Mar 22, 2023
This commit updates parts of the FW to be ES2022 complaint.
These changes are needed to fix the following problems problems with using properties before they are initialized.
Example
```ts
class Foo {
bar = this.buz;
constructor(private buz: unknown){}
}
```
PR Close #49332
atscott
pushed a commit
that referenced
this pull request
Mar 22, 2023
google-closure-compiler does not support ES2022 (cherry picked from commit 54365418bb8388ffa9b6388ae438e4d6ac4e081d) PR Close #49332
atscott
pushed a commit
that referenced
this pull request
Mar 22, 2023
These are currently broken due to the APF v16 changes which dropped support for ES2015. PR Close #49332
atscott
pushed a commit
that referenced
this pull request
Mar 22, 2023
This commit patches `ts_library` to be able to produce `ES2022`. Also, updates the build tsconfig and sets `useDefineForClassFields` to `false` to keep the same behaviour of `ng_module`. PR Close #49332
atscott
pushed a commit
that referenced
this pull request
Mar 22, 2023
Benchpress requires a decent amount of work to be ES2022 compliant. This will be done in a followup PR. PR Close #49332
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 22, 2023
This reverts commit 262c989.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 22, 2023
This reverts commit 9c3f8d5.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 22, 2023
This reverts commit 4d89696.
atscott
added a commit
to atscott/angular
that referenced
this pull request
Mar 22, 2023
This reverts commit 349ff01.
atscott
added a commit
that referenced
this pull request
Mar 22, 2023
atscott
added a commit
that referenced
this pull request
Mar 22, 2023
atscott
added a commit
that referenced
this pull request
Mar 22, 2023
atscott
added a commit
that referenced
this pull request
Mar 22, 2023
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several updates to Angular Package Format.
BREAKING CHANGE:
Several changes to the Angular Package Format (APF)