feat(router): exposes the fixture of the RouterTestingHarness#50280
Closed
JeanMeche wants to merge 1 commit intoangular:mainfrom
Closed
feat(router): exposes the fixture of the RouterTestingHarness#50280JeanMeche wants to merge 1 commit intoangular:mainfrom
fixture of the RouterTestingHarness#50280JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
AndrewKushnir
added
action: review
atscott
added
target: minor
Contributor
JeanMeche
changed the title
fixture of the RouterTestingHarnessfixture of the RouterTestingHarness
JeanMeche
force-pushed
the
refactor/router-harness
branch
from
9e8554a to
f39bab4
Compare
JeanMeche
force-pushed
the
refactor/router-harness
branch
from
f39bab4 to
0b6075d
Compare
Member
|
@JeanMeche can you update the commit description to summarize the usefulness of exposing |
JeanMeche
force-pushed
the
refactor/router-harness
branch
from
0b6075d to
2758b36
Compare
The component exposed by the fixture is not important thus marked as `unknown`. Exposing the fixture of the `RouterTestingHarness` allows to use the methods & properties of that fixture and makes it compatible with testing libraries relying on `ComponentFixture` Fixes angular#48855
JeanMeche
force-pushed
the
refactor/router-harness
branch
from
2758b36 to
75c5ffe
Compare
alxhub
approved these changes
Jun 12, 2023
Member
alxhub
left a comment
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: global-approvers
alxhub
added
action: merge
Member
|
This PR was merged into the repository by commit 0b14e4e. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
…gular#50280) The component exposed by the fixture is not important thus marked as `unknown`. Exposing the fixture of the `RouterTestingHarness` allows to use the methods & properties of that fixture and makes it compatible with testing libraries relying on `ComponentFixture` Fixes angular#48855 PR Close angular#50280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component exposed by the fixture is not important thus marked as
unknown.Fixes #48855
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?