docs(docs-infra): generate errors and extended-diagnostics route NavigationItem-s#59355
Closed
hawkgs wants to merge 2 commits intoangular:mainfrom
Closed
docs(docs-infra): generate errors and extended-diagnostics route NavigationItem-s#59355hawkgs wants to merge 2 commits intoangular:mainfrom
hawkgs wants to merge 2 commits intoangular:mainfrom
Conversation
angular-robot
bot
added
area: docs
hawkgs
force-pushed
the
docs/route-nav-items-gen
branch
from
95062fd to
69c57ed
Compare
josephperrott
requested changes
Jan 6, 2025
hawkgs
force-pushed
the
docs/route-nav-items-gen
branch
from
69c57ed to
b6844ab
Compare
…gationItem-s Generate the `NavigationItem`-s as part of adev/shared-docs pipeline and use the output JSON files instead of the hardcoded objects in the `sub-navigation-data.ts`.
hawkgs
force-pushed
the
docs/route-nav-items-gen
branch
from
48e79db to
c1e3870
Compare
…te NavigationItem-s Update code comments and improve MD file heading extraction.
hawkgs
force-pushed
the
docs/route-nav-items-gen
branch
from
c1e3870 to
02d37b4
Compare
|
Deployed adev-preview for 02d37b4 to: https://ng-dev-previews-fw--pr-angular-angular-59355-adev-prev-nigq0hj9.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
JeanMeche
added
action: merge
Contributor
|
This PR was merged into the repository by commit 220608e. The changes were merged into the following branches: main, 19.0.x, 19.1.x |
PrajaktaB27
pushed a commit
to PrajaktaB27/angular
that referenced
this pull request
Feb 7, 2025
…gationItem-s (angular#59355) Generate the `NavigationItem`-s as part of adev/shared-docs pipeline and use the output JSON files instead of the hardcoded objects in the `sub-navigation-data.ts`. PR Close angular#59355
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Handles: #55593
What is the new behavior?
Generate the
NavigationItem-s of theerrorsandextended-diagnosticsroutes as part of adev/shared-docs pipeline (at build time) and use the output JSON files instead of the hardcoded objects in thesub-navigation-data.ts.The generator can be used for substituting most of the hardcoded data in
sub-navigation-data.tsbut I haven't done it yet since I think it's better having a review of the Bazel package design (the strategies part, I guess).Does this PR introduce a breaking change?