fix(cdk/a11y): live announcer not working with aria-modal element#25978
Merged
crisbeto merged 1 commit intoangular:mainfrom Nov 16, 2022
Merged
fix(cdk/a11y): live announcer not working with aria-modal element#25978crisbeto merged 1 commit intoangular:mainfrom
crisbeto merged 1 commit intoangular:mainfrom
Conversation
crisbeto
added
P2
devversion
reviewed
Nov 15, 2022
devversion
approved these changes
Nov 15, 2022
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. Makes sense. Could potentially leave a comment, but I think the PR is also sufficient.
marcianx
reviewed
Nov 15, 2022
When an `aria-modal="true"` element is present, some browsers exclude all the content outside of them from the a11y tree which breaks the `LiveAnnouncer`. These changes add some logic to set an `aria-owns` on the modals so that the announcement is made. Fixes angular#22733.
crisbeto
force-pushed
the
22733/live-announcer-aria-modal
branch
from
ad07ea2 to
a615ae5
Compare
crisbeto
added a commit
that referenced
this pull request
Nov 16, 2022
…5978) When an `aria-modal="true"` element is present, some browsers exclude all the content outside of them from the a11y tree which breaks the `LiveAnnouncer`. These changes add some logic to set an `aria-owns` on the modals so that the announcement is made. Fixes #22733. (cherry picked from commit a1357a4)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an
aria-modal="true"element is present, some browsers exclude all the content outside of them from the a11y tree which breaks theLiveAnnouncer.These changes add some logic to set an
aria-ownson the modals so that the announcement is made.Fixes #22733.