fix(material/datepicker): resolve typing issue when extending datepicker input in legacy app#25988
Merged
crisbeto merged 1 commit intoangular:mainfrom Nov 16, 2022
Conversation
…ker input in legacy app In the switch to MDC we kept the reference to `MatFormField` in the datepicker input's constructor which now has a slightly different public API, causing a compilation error for apps that were passing in the legacy form field. These changes replace the reference with an interface that contains only the common members that the datepicker cares about. Fixes angular#25977.
crisbeto
added
P3
crisbeto
added a commit
that referenced
this pull request
Nov 16, 2022
…ker input in legacy app (#25988) In the switch to MDC we kept the reference to `MatFormField` in the datepicker input's constructor which now has a slightly different public API, causing a compilation error for apps that were passing in the legacy form field. These changes replace the reference with an interface that contains only the common members that the datepicker cares about. Fixes #25977. (cherry picked from commit a38e08a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the switch to MDC we kept the reference to
MatFormFieldin the datepicker input's constructor which now has a slightly different public API, causing a compilation error for apps that were passing in the legacy form field.These changes replace the reference with an interface that contains only the common members that the datepicker cares about.
Fixes #25977.