Skip to content

fix(material/core): reintroduce opacity in elevation mixin#26015

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:26004/elevation-opacity
Nov 18, 2022
Merged

fix(material/core): reintroduce opacity in elevation mixin#26015
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:26004/elevation-opacity

Conversation

@crisbeto
Copy link
Member

During the switch to MDC the opacity parameter to the elevation mixin was removed which is a breaking change. It also isn't possible to achieve the same result by providing an rgba color, because MDC changes the color's opacity.

Fixes #26004.

During the switch to MDC the opacity parameter to the `elevation` mixin was removed which is a breaking change. It also isn't possible to achieve the same result by providing an `rgba` color, because MDC changes the color's opacity.

Fixes angular#26004.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 18, 2022
@crisbeto crisbeto requested a review from mmalerba November 18, 2022 08:46
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 18, 2022
@crisbeto crisbeto merged commit 48153cb into angular:main Nov 18, 2022
crisbeto added a commit that referenced this pull request Nov 18, 2022
During the switch to MDC the opacity parameter to the `elevation` mixin was removed which is a breaking change. It also isn't possible to achieve the same result by providing an `rgba` color, because MDC changes the color's opacity.

Fixes #26004.

(cherry picked from commit 48153cb)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(ELEVATION): Custom opacity for elevation not took in consideration

2 participants