fix(material/schematics): ensure mdc migration compatibility with nx#26027
Merged
mmalerba merged 1 commit intoangular:mainfrom Nov 19, 2022
Merged
fix(material/schematics): ensure mdc migration compatibility with nx#26027mmalerba merged 1 commit intoangular:mainfrom
mmalerba merged 1 commit intoangular:mainfrom
Conversation
by adding missing `"multiselect": true` in the x-prompt for the `components` property
devversion
approved these changes
Nov 18, 2022
clydin
approved these changes
Nov 18, 2022
Member
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
Technically not required by the Angular CLI since multiselect will automatically default to true based on the schema property type. But if other tools don't currently have that logic then it is fine and won't break anything to be explicit.
Contributor
Author
|
Yeah I'll keep it since i makes the intent more clear and has better tooling support |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by adding missing
"multiselect": truein the x-prompt for thecomponentsproperty