Skip to content

fix(material/form-field): change selector to allow density class on form field#26075

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:26062/form-field-density
Nov 29, 2022
Merged

fix(material/form-field): change selector to allow density class on form field#26075
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:26062/form-field-density

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 24, 2022

Fixes that one of the form field density selectors was targeting .mat-mdc-form-field which prevents users from setting density classes directly on the form field.

Fixes #26062.

@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Nov 24, 2022
@crisbeto crisbeto mentioned this pull request Nov 24, 2022
Closed
1 task
@crisbeto
fix(material/form-field): change selector to allow density class on f…
0947a2b 
…orm field

Fixes that one of the form field density selectors was targeting `.mat-mdc-form-field` which prevents users from setting density classes directly on the form field.

Fixes angular#26062.
@crisbeto crisbeto force-pushed the 26062/form-field-density branch from 7cdee1d to 0947a2b Compare November 24, 2022 12:27
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 26, 2022
@crisbeto crisbeto self-assigned this Nov 26, 2022
@crisbeto crisbeto merged commit dab1930 into angular:main Nov 29, 2022
crisbeto added a commit that referenced this pull request Nov 29, 2022
@crisbeto
fix(material/form-field): change selector to allow density class on f…
00618a9 
…orm field (#26075)

Fixes that one of the form field density selectors was targeting `.mat-mdc-form-field` which prevents users from setting density classes directly on the form field.

Fixes #26062.

(cherry picked from commit dab1930)
@electrofLy electrofLy mentioned this pull request Dec 1, 2022
Closed
1 task
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 30, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(form-field): Labels not vertically aligned correctly when using custom densities

2 participants

@crisbeto @devversion