Skip to content

fix(material/slide-toggle): focus indication not showing inside OnPush parent#26111

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:slide-toggle-focus-onpush
Nov 29, 2022
Merged

fix(material/slide-toggle): focus indication not showing inside OnPush parent#26111
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:slide-toggle-focus-onpush

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 29, 2022

Fixes that the focus indication wasn't showing up when the slide toggle is placed inside of an OnPush component.

@crisbeto
fix(material/slide-toggle): focus indication not showing inside OnPus…
222502f 
…h parent

Fixes that the focus indication wasn't showing up when the slide toggle is placed inside of an `OnPush` component.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Nov 29, 2022
@crisbeto crisbeto requested a review from devversion November 29, 2022 05:37
@crisbeto crisbeto self-assigned this Nov 29, 2022
mmalerba
mmalerba approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2022
@crisbeto crisbeto merged commit 3d3767f into angular:main Nov 29, 2022
crisbeto added a commit that referenced this pull request Nov 29, 2022
@crisbeto
fix(material/slide-toggle): focus indication not showing inside OnPus…
1566ab1 
…h parent (#26111)

Fixes that the focus indication wasn't showing up when the slide toggle is placed inside of an `OnPush` component.

(cherry picked from commit 3d3767f)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 30, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

+1 more reviewer

@mmalerba mmalerba mmalerba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crisbeto @devversion @mmalerba