fix(cdk/menu): not closing when inside shadow DOM#26112
Merged
crisbeto merged 1 commit intoangular:mainfrom Nov 29, 2022
Merged
fix(cdk/menu): not closing when inside shadow DOM#26112crisbeto merged 1 commit intoangular:mainfrom
crisbeto merged 1 commit intoangular:mainfrom
Conversation
Fixes that the CDK menu wasn't closing on outside clicks when the trigger is inside the shadow DOM. The problem is that reading the `Event.target` doesn't work as expected in the shadow DOM and we have to go through a helper. Fixes angular#26107.
crisbeto
added
P3
crisbeto
commented
Nov 29, 2022
| ) | ||
| .subscribe(() => { | ||
| // Closes any sibling menu items and opens the menu associated with this trigger. | ||
| const toggleMenus = () => |
Member
Author
There was a problem hiding this comment.
Unrelated change, I just noticed that we can move this function closer to its call site.
devversion
approved these changes
Nov 29, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that the CDK menu wasn't closing on outside clicks when the trigger is inside the shadow DOM. The problem is that reading the
Event.targetdoesn't work as expected in the shadow DOM and we have to go through a helper.Fixes #26107.