Skip to content

perf(material/chips): reduce amount of macro tasks#26113

Merged
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:chips-timeout-perf
Nov 29, 2022
Merged

perf(material/chips): reduce amount of macro tasks#26113
crisbeto merged 1 commit intoangular:mainfrom
crisbeto:chips-timeout-perf

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 29, 2022 •
edited
Loading

  • Fixes that the chip grid was triggering a bunch of change detections on initialization through a setTimeout inside setDescribedByIds.
  • Replaces most of the remaining timeouts in the chips with Promise.resolve.

Fixes #25325.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Nov 29, 2022
@crisbeto crisbeto self-assigned this Nov 29, 2022
@crisbeto crisbeto mentioned this pull request Nov 29, 2022
Closed
@crisbeto crisbeto force-pushed the chips-timeout-perf branch 2 times, most recently from 980ef79 to 327d117 Compare November 29, 2022 16:17
@crisbeto
perf(material/chips): reduce amount of macro tasks
37d78cd 
* Fixes that the chip grid was triggering a bunch of change detections on initialization through a `setTimeout` inside `setDescribedByIds`.
* Replaces most of the remaining timeouts in the chips with `Promise.resolve`.

Fixes angular#25325.
zarend
zarend approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2022
@crisbeto crisbeto merged commit 33db089 into angular:main Nov 29, 2022
crisbeto added a commit that referenced this pull request Nov 29, 2022
@crisbeto
perf(material/chips): reduce amount of macro tasks (#26113)
7755aa5 
* Fixes that the chip grid was triggering a bunch of change detections on initialization through a `setTimeout` inside `setDescribedByIds`.
* Replaces most of the remaining timeouts in the chips with `Promise.resolve`.

Fixes #25325.

(cherry picked from commit 33db089)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 30, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

1 more reviewer

@zarend zarend zarend approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crisbeto crisbeto

Labels

action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(material-experimental/mdc-chips): Poor performance when using multiple <mat-chip-grid> components

2 participants

@crisbeto @zarend