fix(material/snack-bar): incorrect width at some breakpoints#26334
Merged
crisbeto merged 1 commit intoangular:mainfrom Jan 5, 2023
Merged
fix(material/snack-bar): incorrect width at some breakpoints#26334crisbeto merged 1 commit intoangular:mainfrom
crisbeto merged 1 commit intoangular:mainfrom
Conversation
crisbeto
added
P3
crisbeto
commented
Dec 28, 2022
| // of positions, so we'll defer logic there. | ||
| position: static; | ||
|
|
||
| @include cdk.high-contrast(active, off) { |
Member
Author
There was a problem hiding this comment.
Unrelated change. I just noticed that we don't need it anymore.
jelbourn
reviewed
Jan 3, 2023
| $query: mdc-helpers.$mdc-base-styles-query | ||
| ); | ||
|
|
||
| // The MDC `min-width` mixin has a similar breakpoint that sets `min-width: 100%` on the surfcace |
Contributor
There was a problem hiding this comment.
Suggested change
| // The MDC `min-width` mixin has a similar breakpoint that sets `min-width: 100%` on the surfcace | |
| // The MDC `min-width` mixin has a similar breakpoint that sets `min-width: 100%` on the surface |
Comment on lines
+24
to
+25
| // element to make it span the entire viewport, however it ends up collapsing because the | ||
| // container is `width: auto`. This query ensures that the surface will span the whole viewport. |
Contributor
There was a problem hiding this comment.
Should we open an issue OR code change with MDC for this? It seems like 100vw more closely matches the intent of their style
Member
Author
There was a problem hiding this comment.
MDC would've been 100vw as well, but we override their position: fixed positioning in order to fit the snack bar in our overlay positioning model.
MDC has some built in breakpoints where the snack bar container becomes `min-width: 100%`. They didn't work correctly, because the container wasn't set up to be 100% wide. Fixes angular#26290.
crisbeto
force-pushed
the
26290/snack-bar-width
branch
from
0c61dcc to
b7fdbd8
Compare
devversion
approved these changes
Jan 5, 2023
crisbeto
added a commit
that referenced
this pull request
Jan 5, 2023
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 8, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.0.3` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.0.3/15.0.4) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.0.3` -> `15.0.4`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.0.3/15.0.4) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.0.4`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1504-spandex-sword-2023-01-05) [Compare Source](angular/components@15.0.3...15.0.4) ##### material | Commit | Type | Description | | -- | -- | -- | | [e7fc766379](angular/components@e7fc766) | fix | **menu:** aria-expanded not updating in an OnPush component ([#​26279](angular/components#26279)) | | [caa8f7b005](angular/components@caa8f7b) | fix | **menu:** prevent pointer events on animating menu ([#​26323](angular/components#26323)) | | [ee63ad32b2](angular/components@ee63ad3) | fix | **slider:** avoid updating tick marks unnecessarily ([#​26322](angular/components#26322)) | | [41cfc6e2f4](angular/components@41cfc6e) | fix | **slider:** dragEnd not being emitted ([#​26289](angular/components#26289)) | | [6c4a1f74b4](angular/components@6c4a1f7) | fix | **slider:** value jumping after drag with box-sizing: border-box ([#​26345](angular/components#26345)) | | [b52cd63bb1](angular/components@b52cd63) | fix | **snack-bar:** incorrect width at some breakpoints ([#​26334](angular/components#26334)) | | [5cce2fe6d6](angular/components@5cce2fe) | fix | **snack-bar:** set explicit color on action in dark themes ([#​26268](angular/components#26268)) | | [3e50216f6d](angular/components@3e50216) | fix | **tabs:** touch gestures not working on tab nav bar ([#​26344](angular/components#26344)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [70cf080cd5](angular/components@70cf080) | fix | **popover-edit:** Make cell focus indicator visible in high contrast (forced colors) mode ([#​26275](angular/components#26275)) | #### Special Thanks Daniel, Karl Seamon, Kristiyan Kostadinov, Paul Gschwendtner and Wagner Maciel <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC44My4xIiwidXBkYXRlZEluVmVyIjoiMzQuODQuMSJ9--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1702 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDC has some built in breakpoints where the snack bar container becomes
min-width: 100%. They didn't work correctly, because the container wasn't set up to be 100% wide.Fixes #26290.