Skip to content

Fix typo: Celcius -> Celsius#1347

Merged
angularsen merged 1 commit intoangularsen:release/v6from
Muximize:fix-celcius-celsius
Jan 2, 2024
Merged

Fix typo: Celcius -> Celsius#1347
angularsen merged 1 commit intoangularsen:release/v6from
Muximize:fix-celcius-celsius

Conversation

@Muximize
Copy link
Contributor

@Muximize Muximize commented Jan 2, 2024

Came across this while working on #1329. I'm afraid it's an API-breaking change, so maybe it should wait for v6?

@angularsen
Copy link
Owner

angularsen commented Jan 2, 2024

Nice catch.
Yes, this would be a breaking change on FromXXX factory methods among other things. Let's target v6 branch and merge it there. We don't have a good way of marking only the plural form as obsolete though, so people will only be able to migrate when upgrading.

@Muximize Muximize force-pushed the fix-celcius-celsius branch from a138bcd to 6f9dec8 Compare January 2, 2024 12:16
@Muximize Muximize changed the base branch from master to release/v6 January 2, 2024 12:17
@Muximize
Copy link
Contributor Author

Muximize commented Jan 2, 2024

Sounds like a plan! I rebased this and targeted v6.

@angularsen angularsen merged commit cff63a6 into angularsen:release/v6 Jan 2, 2024
@angularsen
Copy link
Owner

Related:
#1200

@angularsen angularsen mentioned this pull request Jan 2, 2024
25 tasks
@Muximize Muximize deleted the fix-celcius-celsius branch January 6, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants