Implicit cast between Duration and TimeSpan#1365
Merged
angularsen merged 9 commits intoangularsen:release/v6from Feb 26, 2024
Merged
Implicit cast between Duration and TimeSpan#1365angularsen merged 9 commits intoangularsen:release/v6from
angularsen merged 9 commits intoangularsen:release/v6from
Conversation
Contributor
Author
|
Hmm, these failing CI tests pass on my machine. Any guidance? |
Owner
|
@Muximize I can't think of any, so I'd say let's just make a breaking change and not support it. For multiplication, they can switch order. |
Owner
|
As for the failing test case, that was my bad in a previous merged PR. |
Contributor
Author
|
I completely removed Also removed some tests for |
angularsen
requested changes
Feb 26, 2024
Owner
angularsen
left a comment
angularsen
left a comment
There was a problem hiding this comment.
Another mistake on my part, I'll fix it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1354 (comment)
One issue is that the operator overloads only work when
TimeSpanis the right operand.I changed the code generation to take this into account, but another option would be to make a breaking change where we just don't support
TimeSpanas the left operand at all.Then users would have to cast explicitly, or for multiplication just reverse the operands.
This would affect 13 operators:
Of which only 6 are used in tests so I assume are supported in v5: